-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate JAXB v4. #73
base: master
Are you sure you want to change the base?
Conversation
1d2dcc1
to
78ffb1a
Compare
When is this going to be merged? |
No particular deadlines at the moment. There have been a few unit tests failing, which I decoded to revisit later, but that didn't happen yet. Good there is an interest, that motivates to finalize the changes. |
The EU DSS library devs were waiting for the org.jvnet.jaxb:jax-maven-plugin v4 to be released. This version was released last week with JAXB 4 support. But they still use your plugin aswell but it doesn't support JAXB 4 yet. This blocks their Javax -> Jakarta update and therefor blocks our Spring Boot 2 -> 3 update of which version 2 is end of life next month. So there seems to be a lot connected to this particular plugin, it would be a great joy if you could find some time to fix the failing tests and merge this MR sooner rather than later. |
Give me a few weeks, I'll make my best to merge & release a new version. End of Q3 a bit crazy... |
It seems that only XmlElementWrapperPluginTest is failing. I was trying to figure out why and it seems there is some problem with loading proper JAXBContextFactory from jaxb.properties for inner_element_value_objects package. I was able to fix it by adding conditional creation of JAXBContext via custom jaxbContextFactory from jaxb.properties in compileAndLoad method:
It looks ugly, but worked. Also I bumped jaxb-api.version to 4.0.1, removed dependency to io.earcam.wrapped:jdk.compile and add exclusions for org.xmlunit:xmlunit-jakarta-jaxb-impl (for jakarta.xml.bind-api and jaxb-runtime) hope it helps. |
Depends on: issue #1678.